Repository navigation
Conversation
--interval was passed straight through to time.sleep() with no validation, so a negative value crashed with an unhandled ValueError instead of a normal CLI error, and 0 turned the watch loop into a busy-loop. Fixes ControlCore-Project#582
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #582
`--interval` was passed straight through to `time.sleep(interval)` with no validation. A negative value crashed with an unhandled `ValueError: sleep length must be non-negative` instead of a normal CLI error, and `0` turned the watch loop into a busy-loop.
Now `concore watch` rejects `--interval <= 0` up front and prints a normal `[red]Error:[/red]` message, consistent with how the other commands in `cli.py` handle bad input.
Added two tests covering the negative and zero cases.